Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite <Input> and <TextArea> components to be fully controlled #307

Merged
merged 1 commit into from
May 25, 2018
Merged

Rewrite <Input> and <TextArea> components to be fully controlled #307

merged 1 commit into from
May 25, 2018

Conversation

sindresorhus
Copy link
Contributor

Since our state updates are async, it creates a race condition where React cannot correctly diff the updates and it results in the cursor being pushed to the end.

See this React issue: facebook/react#955 In short, just another React annoyance.

Fixes #237

@sindresorhus
Rewrite <Input> and <TextArea> components to be fully controlled
17682b8 
Since our state updates are async, it creates a race condition where React cannot correctly diff the updates and it results in the cursor being pushed to the end.

See this React issue: facebook/react#955 In short, just another React annoyance.

Fixes #237
@sindresorhus
Copy link
Contributor Author

Note that 26eab29 overrides this fix for number inputs. So number inputs will not be fixed for this issue until React fixes it. It's impossible to fix both.

@sindresorhus sindresorhus merged commit 8ce7d6d into master May 25, 2018
@sindresorhus sindresorhus deleted the fix-inputs branch May 25, 2018 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukechilds lukechilds lukechilds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sindresorhus @lukechilds